Skip to content

Rollup of 11 pull requests#154559

Merged
rust-bors[bot] merged 24 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-Iut0qjN
Mar 30, 2026
Merged

Rollup of 11 pull requests#154559
rust-bors[bot] merged 24 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-Iut0qjN

Conversation

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

homersimpsons and others added 24 commits March 4, 2026 01:00
Co-authored-by: stifskere <esteve@memw.es>
Similar to the existing `IoLines` item.  It will be used in Clippy to
detect uses of `Split` leading to infinite loops similar to the existing
lint for `Lines`.
This is now exposed via `sysctl` as of macOS "Tahoe" 26.4 (or possibly earlier).
#docs doesn't seem to exist anymore, so point people to `t-libs`.
Also include direct link to topic since Zulip is world-viewable now.
Exercises a self-referencing type alias with lazy_type_alias and
min_generic_const_args, which previously caused an ICE during
normalization.
…ulacrum

don't drop arguments' temporaries in `dbg!`

Fixes rust-lang#153850

Credit to @theemathas for help with macro engineering ^^

r? libs
…inarycat

rustdoc: add missing {os,target,target_env} values for cfg pretty printer
…ble-path-suggestion, r=estebank

Fix invalid type suggestion for item nested in function

Fixes rust-lang#146786

I also tried to add the `omit_parent` logic in pretty formatter here:
https://github.com/chenyukang/rust/blob/69b6d26d05006dca7556abc555fb0e029ecf1f4e/compiler/rustc_middle/src/ty/print/pretty.rs#L2240-L2295
so that we don't need to add `should_omit_parent_def_path` and `reset_path`.

but seems there will be duplicate print code with `default_print_def_path`.

maybe r? @estebank
…henyukang

Add regression test for recursive lazy type alias normalization ICE

Regression test for rust-lang#152633.

The normalization ICE with recursive lazy_type_alias + min_generic_const_args was fixed by rust-lang#152040 but didn't get a test. Compiler now reports E0275 instead of crashing.

Closes rust-lang#152633
…alueFormat-powerpc, r=marcoieni

Fix LegacyKeyValueFormat report from docker build: powerpc

Part of rust-lang#152305

r? @marcoieni
…Simulacrum

feat: reimplement `hash_map!` macro

originally implemented in rust-lang#144070, this had to be reverted in rust-lang#148049 due to name ambiguity, as the macro was automatically put into the prelude. now, that rust-lang#139493 has landed, it is possible to have a top-level macro, that is not exported by default, which should make it possible to reland this again.

implements rust-lang#144032
implementation from rust-lang#144070, original author has been added as co-author
effectively reverts rust-lang#148049
Add `IoSplit` diagnostic item for `std::io::Split`

Similar to the existing `IoLines` item.  It will be used in Clippy to detect uses of `Split` leading to infinite loops similar to the existing lint for `Lines`.
…ulacrum

std_detect on AArch64 Darwin: Detect FEAT_SVE_B16B16

This is now exposed via `sysctl` as of macOS "Tahoe" 26.4 (or possibly earlier).
…e, r=jieyouxu

Fix ambiguous parsing in bootstrap.py

Noticed this while trying to produce rustdoc-json for std and saw JSON output from the bootstrap.py build of bootstrap's Rust code. This is technically a breaking change, but I think the fix should be simple and arguably an improvement in future compatibility if/when the flag set changes.
…l, r=Noratrieb

update zulip link in `std` documentation

#docs doesn't seem to exist anymore, so point people to `t-libs`. Also include direct link to topic since Zulip is world-viewable now.
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Mar 29, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never p=5

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 29, 2026
@rustbot rustbot added T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Mar 29, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 29, 2026

📌 Commit de649f4 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

Trying commonly failed jobs
@bors try jobs=test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Mar 29, 2026
Rollup of 11 pull requests


try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 29, 2026

☀️ Try build successful (CI)
Build commit: d45acf4 (d45acf459dc0ebd498df82127fb2fd4d4365ffbd, parent: cd14b73b4a41542d921f59e362a5b5005fa4f2ef)

@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 30, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 30, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 12m 37s
Pushing 80ad557 to main...

@rust-bors rust-bors bot merged commit 80ad557 into rust-lang:main Mar 30, 2026
13 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 30, 2026
@rust-timer
Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#153373 Fix LegacyKeyValueFormat report from docker build: powerpc de23df060c3017073a582ff907eff892bf54584c (link)
#154074 don't drop arguments' temporaries in dbg! 05f4caf354a93307f08b76a0c4ea65bb9f8f251d (link)
#154322 feat: reimplement hash_map! macro 48613c8f6412f9f443b66b3b9519a4db74eec1c9 (link)
#154328 rustdoc: add missing {os,target,target_env} values for cfg … 5531d45339e4b4633294c3a07b039c201b7a22c7 (link)
#154416 Add IoSplit diagnostic item for std::io::Split 284fc6ca37c10530e8cbe83e9809cc6979f14b3a (link)
#154486 std_detect on AArch64 Darwin: Detect FEAT_SVE_B16B16 eb3ae5164ed96efc68145e267a8b073eeb17f29e (link)
#154508 Fix ambiguous parsing in bootstrap.py 3c493e764bf70f49cadcdb1422c9c58fe9a4cd43 (link)
#154518 Panic in Hermit clock_gettime 45574625e4595eba6d7da764752abe4dddc43bd9 (link)
#154530 update zulip link in std documentation 7c7108fb2c052c05d1a71f477e36075f9d69e0ad (link)
#154540 Fix invalid type suggestion for item nested in function d5973da47f6f1a808e5e752f65f696ea54ec17c5 (link)
#154549 Add regression test for recursive lazy type alias normaliza… 7a1f92615c78cfba2f14c718905f7ed1b7b11113 (link)

previous master: a25435bcf7

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Copy Markdown
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a25435b (parent) -> 80ad557 (this PR)

Test differences

Show 84 test diffs

Stage 1

  • [rustdoc-html] tests/rustdoc-html/doc-cfg/all-targets.rs: [missing] -> pass (J2)
  • [ui] tests/ui/suggestions/function-local-item-type-suggestion-issue-146786.rs: [missing] -> pass (J2)
  • [ui] tests/ui/type-alias/recursive-lazy-type-alias-ice-152633.rs: [missing] -> pass (J2)
  • macros::tests::no_dropping_temps: [missing] -> pass (J4)

Stage 2

  • [ui] tests/ui/suggestions/function-local-item-type-suggestion-issue-146786.rs: [missing] -> pass (J0)
  • [ui] tests/ui/type-alias/recursive-lazy-type-alias-ice-152633.rs: [missing] -> pass (J0)
  • [rustdoc-html] tests/rustdoc-html/doc-cfg/all-targets.rs: [missing] -> pass (J1)
  • macros::tests::no_dropping_temps: [missing] -> pass (J3)

Additionally, 76 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 80ad55752e5ae6c2d1bc143b819eb8d1c00167d1 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 32m 10s -> 35m 51s (+11.5%)
  2. i686-gnu-1: 2h 26m -> 2h 10m (-11.1%)
  3. dist-x86_64-apple: 2h 5m -> 1h 51m (-10.9%)
  4. x86_64-gnu-llvm-21-2: 1h 39m -> 1h 29m (-10.0%)
  5. x86_64-gnu-tools: 1h 1m -> 1h 6m (+8.2%)
  6. dist-arm-linux-gnueabi: 1h 28m -> 1h 21m (-7.9%)
  7. dist-powerpc-linux: 1h 34m -> 1h 27m (-7.8%)
  8. dist-s390x-linux: 1h 31m -> 1h 24m (-7.5%)
  9. x86_64-gnu-distcheck: 2h 19m -> 2h 9m (-7.1%)
  10. x86_64-gnu-debug: 2h 1m -> 2h 10m (+6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.